Re: [PATCH] Handle double slashes in make_relative_path()

From: Robin Rosenberg <robin.rosenberg@dewire.com>
Date: Jan 23, 2010, 11:40 UTC
Message-ID: <201001231240.28138.robin.rosenberg@dewire.com>
In-Reply-To: <4B59637D.4090503@viscovery.net>

fredagen den 22 januari 2010 09.36.13 skrev  Johannes Sixt:

Show 6 quoted lines

> Junio C Hamano schrieb:
> > Credit for test script, motivation and initial patch goes to Thomas Rast,
> > but the bugs in the implementation of this patch are mine..
> 
> And with this squashed in it has fewer of them ;-) and is more portable.
> The bug was that /foo was incorrectly stripped from /foobar.

It seems this function does something unhealthy when you pass a path of the form //server/share. On windows dropping the double // at the beginning makes it a different path since // is the UNC prefix.

I'm not sure git on windows actually works with UNC-prefix anyway, so my point may be moot, but having even more places to fix to make it work doesn't help.

-- robin