Re: [PATCH] sha1_file: don't malloc the whole compressed result when writing out objects

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 22, 2010, 19:55 UTC
Message-ID: <7vmxz1dozk.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.2.00.1002221233000.1946@xanadu.home>

Nicolas Pitre <nico@fluxnic.net> writes:

Show 8 quoted lines

>> Having said all that, I like your approach better.  It is not worth paying
>> the price of unnecessary memcpy(3) that would _only_ help catching the
>> insanely artificial test case, but your patch strikes a good balance of
>> small overhead to catch the easier-to-trigger (either by stupidity, malice
>> or mistake) cases.
>
> I think it also catches the bad RAM case which is probably more common 
> too.

That is true; a broken RAM that returns unstable values will yield different values between the time the first hash runs and the time the deflate loop runs will trigger the safety.