Re: [PATCH] sha1_file: don't malloc the whole compressed result when writing out objects
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 21, 2010, 19:45 UTC
- Message-ID
- <7vd3zys79d.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <alpine.LFD.2.00.1002202323500.1946@xanadu.home>
Nicolas Pitre <nico@fluxnic.net> writes:
> I think this is worth doing independently of the paranoid mode being > discussed.
While I agree it might be worth doing, I can see that you really hate "paranoia". Now your loop is letting deflate() decide how much it happens to like to consume in a given round, it is much trickier to plug the paranoia in without majorly rewriting the loop this patch introduces.