Re: [PATCH] sha1_file: don't malloc the whole compressed result when writing out objects
- From
Dmitry Potapov <dpotapov@gmail.com>
- Date
- Feb 22, 2010, 06:27 UTC
- Message-ID
- <20100222062713.GD10191@dpotapov.dyndns.org>
- In-Reply-To
- <alpine.LFD.2.00.1002220034540.1946@xanadu.home>
On Mon, Feb 22, 2010 at 12:50:18AM -0500, Nicolas Pitre wrote:
> > And what real life case would trigger this? Given the size of the > window for this to happen, what are your chances?
If some process changes just one byte (or one word) back and forth then the possibility of this is 25%. Whether such a process can exist, I don't know... I could not imagine that anyone would want to change the file when we add it to the repository. In any case, it is wrong to call it a _paranoic_ mode if there is even a small (but practically feasable) chance of this to happen.
Dmitry