Re: [PATCH v3 0/5] make open/unlink failures user friendly on windows using retry/abort
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 15, 2010, 20:45 UTC
- Message-ID
- <7vmxo6pxyi.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <AANLkTiks1drfpu9eR6S7KQ9X2MgVy91QAfKs-SRF_voG@mail.gmail.com>
Erik Faye-Lund <kusmabite@gmail.com> writes:
> Perhaps instead we would be better of with something like an xunlink > (etc) in wrapper.c that deals with this on all platforms (and make > sure that unlink sets errno to EBUSY correctly if it doesn't already)?
That is superficially similar to the way we let xread() silently handle short read to give us an easier to use API. Especially, the part to silently retry for a few times is similar to xread() recovering by repeating short reads.
I do not think "ask the user one last time" part belongs to such a wrapper, though.