[PATCH v3 0/5] make open/unlink failures user friendly on windows using retry/abort
- From
Heiko Voigt <hvoigt@hvoigt.net>
- Date
- Dec 14, 2010, 22:06 UTC
- Message-ID
- <20101214220604.GA4084@sandbox>
Hi,
On Wed, Nov 10, 2010 at 09:32:00PM +0100, Johannes Sixt wrote:
Show 8 quoted lines
> On Dienstag, 9. November 2010, Heiko Voigt wrote: > > So it seems that unlink also has the problem of getting an > > ERROR_ACCESS_DENIED (Code 5) sometimes. Johannes would you agree that > > including this code into the is_file_in_use_error() function and thus > > having the potential risk of a 71ms delay for real access denials for > > these calls makes sense? > > Of course, it matches my own observations.
Sorry for the delay. Here is finally a new iteration of the patch series. I hope I have addressed all raised issues. An extra pair of eyes is appreciated.
This series has been ported to Junios tree.
I also added one patch from Johannes which I think should be part of this series.
Cheers Heiko
Heiko Voigt (4): mingw: move unlink wrapper to mingw.c mingw: work around irregular failures of unlink on windows mingw: make failures to unlink or move raise a question mingw: add fallback for rmdir in case directory is in use
Johannes Schindelin (1): mingw_rmdir: set errno=ENOTEMPTY when appropriate
compat/mingw.c | 172 +++++++++++++++++++++++++++++++++++++++++++++++++++++++- compat/mingw.h | 14 ++--- 2 files changed, 177 insertions(+), 9 deletions(-)
-- 1.7.3.3.566.gf422f