Re: [PATCH 1/4] config: add include directive

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 26, 2012, 20:42 UTC
Message-ID: <7vmx9a2o23.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120126165456.GA5278@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 10 quoted lines

> And no, I didn't do any cycle detection. We could either do:
>
>   1. Record some canonical name for each source we look at (probably
>      realpath() for files, and the sha1 for refs), and don't descend
>      into already-seen sources.
>
>   2. Simply provide a maximum depth, and don't include beyond it.
>
> The latter is much simpler to implement, but I think the former is a
> little nicer for the user.

Another thing I wondered after reading this patch was that it will be a rather common "mistake" to include the same file twice, one in ~/.gitconfig and then another in project specific .git/config, or more likely, people start using useful ones in ~their/.gitconfig, and then the site administrator by popular demand adding the same include in /etc/gitconfig to retroactively cause the same file included twice for them.

Your first alternative solution should solve this case nicely as well, I would think.