Re: [PATCH 1/4] config: add include directive

From: Jeff King <peff@peff.net>
Date: Jan 27, 2012, 05:55 UTC
Message-ID: <20120127055515.GC23633@sigill.intra.peff.net>
In-Reply-To: <7vk44d1zww.fsf@alter.siamese.dyndns.org>

On Thu, Jan 26, 2012 at 09:23:59PM -0800, Junio C Hamano wrote:

Show 11 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > And then because of 1a and 2a, most programs should Just Work without
> > any changes, but because of 1b and 2b, any special uses will have to
> > decide manually whether they would want to allow includes.
> >
> > Does that make sense?
> 
> In short, the "git config" interface defaults to "--no-includes" when
> reading from an explicit file with "-f" and "--includes" otherwise, which
> sounds like a 100% sensible default to me.

Yes, exactly. Thank you for explaining it in about 1/10 the words I needed to use. :)

I'll put that behavior in the re-roll.

Show 9 quoted lines

> > How about:
> >
> >   The included file is processed immediately, before any other
> >   directives from the surrounding file.
> >
> > What I wanted to make clear there is the ordering, which sometimes
> > matters.
> 
> Hmm, I think the original is probably easier to read.

OK, then I'll leave it unless somebody else wants to come up with something brilliant.

-Peff