Re: [PATCH 4/4] config: allow including config from repository blobs

From: Jeff King <peff@peff.net>
Date: Jan 27, 2012, 05:57 UTC
Message-ID: <20120127055722.GD23633@sigill.intra.peff.net>
In-Reply-To: <CACsJy8ASXrmBvxj4DxjGiqYhPkr1Yp02CAyMqKrfyfrzaAw-2g@mail.gmail.com>

On Fri, Jan 27, 2012 at 10:47:29AM +0700, Nguyen Thai Ngoc Duy wrote:

Show 6 quoted lines

> > What happens if a ref cannot be resolved, for example due to repository
> > corruption? Does git just emit an error and then carries on, or does it
> > always die? Can I run at least git-fsck in such a case?
> 
> Moreover, if I specify sha-1 in the config (it's discouraged but not
> forbidden from the code), can git-prune remove the blob?

Yes. I don't think we want to get into connectivity guarantees for config (because they can be quite complex, and involve files totally outside the repo). I think it's OK for the user to be responsible for either using a ref, or making sure that a bare sha1 they point to is reachable from a ref.

-Peff