Re: [PATCH] lessen the impression of unexpectedness on remote hangup
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 11, 2012, 16:41 UTC
- Message-ID
- <7vmx497qd5.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20120610182310.GB2427@book.hvoigt.net>
Heiko Voigt <hvoigt@hvoigt.net> writes:
Show 13 quoted lines
> If a server accessed through ssh is denying access git will currently > issue the message > > "fatal: The remote end hung up unexpectedly" > > as the last line. This sounds as if something really ugly just happened. > Since this is a quite typical situation in which users regularly get > lets just say: > > "fatal: The remote end hung up" > > Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net> > ---
This change makes sense, but you would need to adjust tests for the change, perhaps at least these:
t/t5512-ls-remote.sh | 2 +- t/t5522-pull-symlink.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t5512-ls-remote.sh b/t/t5512-ls-remote.sh index 5c546c9..a24eb42 100755 --- a/t/t5512-ls-remote.sh +++ b/t/t5512-ls-remote.sh @@ -104,7 +104,7 @@ test_expect_success 'use branch.<name>.remote if possible' ' cat >exp <<EOF fatal: 'refs*master' does not appear to be a git repository -fatal: The remote end hung up unexpectedly +fatal: The remote end hung up EOF test_expect_success 'confuses pattern as remote when no remote specified' ' # diff --git a/t/t5522-pull-symlink.sh b/t/t5522-pull-symlink.sh index 8e9b204..f06ffb4 100755 --- a/t/t5522-pull-symlink.sh +++ b/t/t5522-pull-symlink.sh @@ -46,7 +46,7 @@ test_expect_success SYMLINKS 'pulling from real subdir' ' # Instead, the error pull gave was: # # fatal: 'origin': unable to chdir or not a git archive -# fatal: The remote end hung up unexpectedly +# fatal: The remote end hung up # # because git would find the .git/config for the "trash directory" # repo, not for the clone-repo repo. The "trash directory" repo