Re: [PATCH] lessen the impression of unexpectedness on remote hangup

> On Sun, Jun 10, 2012 at 08:23:10PM +0200, Heiko Voigt wrote:
> 
> > If a server accessed through ssh is denying access git will currently
> > issue the message
> > 
> > 	"fatal: The remote end hung up unexpectedly"
> > 
> > as the last line. This sounds as if something really ugly just happened.
> > Since this is a quite typical situation in which users regularly get
> > lets just say:
> > 
> > 	"fatal: The remote end hung up"
> > 
> > Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> > ---
> > We just got this bug report in msysgit
> > 
> > https://github.com/msysgit/msysgit/issues/28
> > 
> > and IIRC there have been more people questioning that line.
> 
> This does not seem like it would lessen the surprise all that much. I
> wonder if we could use some context about where we are in the protocol
> to tell more. For example, if the remote end hangs up before advertising
> its refs, it is probably an authentication error or a missing
> repository. And we should say that. If it happens during ref negotiation
> or during the pack file, then it really is unexpected; the other end has
> broken protocol, and it probably makes sense to say so.