Re: [PATCH v2] remove the impression of unexpectedness when access is denied

From: Jeff King <peff@peff.net>
Date: May 7, 2013, 18:39 UTC
Message-ID: <20130507183937.GA5776@sigill.intra.peff.net>
In-Reply-To: <7vr4hktddq.fsf@alter.siamese.dyndns.org>

On Mon, May 06, 2013 at 07:02:41AM -0700, Junio C Hamano wrote:

Show 7 quoted lines

> >    Would it make sense for the server to send an "ERR" packet to give
> >    a more helpful diagnosis?
> 
> I think git-daemon does so (or at least attempts to do so);
> path_ok() uses enter_repo() to check if the given path is a
> repository, returns NULL to run_service(), whichh in turn calls
> daemon_error() that does the ERR thing.

Yeah, that went into v1.7.8. Do we have any simple way to find out which version kernel.org is running? They should probably also turn on the --informative-errors option, as they do not (AFAIK) have any private repos whose information could be leaked by better error messages.

If they are running v1.7.8 and it is not producing an ERR message, then I think there is a bug.

Show 5 quoted lines

> >  * The error message is the same whether the server returned no
> >    response or an incomplete pkt-line.  Maybe in the latter case it
> >    should print the "hung up unexpectedly" thing.
> 
> OK.

I made a stab at this some time ago:

  http://article.gmane.org/gmane.comp.version-control.git/112189

There were some follow-up comments, and I remember trying to make something work with processing remote stderr, but running into complications. Alas, I don't remember any more details than that. But maybe it helps.

-Peff