Re: [PATCH] git-svnimport: Use separate arguments in the pipe for git-rev-parse
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 18, 2007, 08:54 UTC
- Message-ID
- <7vlkb4wdzq.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20070918074753.GQ31176@kiste.smurf.noris.de>
Matthias Urlichs <smurf@smurf.noris.de> writes:
Show 19 quoted lines
> Signed-Off-By: Matthias Urlichs <smurf@smurf.noris.de>
> ---
> Please tell me whether that works for you.
>
> Somebody else, preferably its author, can fix git-svn. ;-)
>
> diff --git a/git-svnimport.perl b/git-svnimport.perl
> index d3ad5b9..aa5b3b2 100755
> --- a/git-svnimport.perl
> +++ b/git-svnimport.perl
> @@ -633,7 +633,7 @@ sub commit {
>
> my $rev;
> if($revision > $opt_s and defined $parent) {
> - open(H,"git-rev-parse --verify $parent |");
> + open(H,'-|',"git-rev-parse","--verify",$parent);
> $rev = <H>;
> close(H) or do {
> print STDERR "$revision: cannot find commit '$parent'!\n";I seem to be missing the context, but please describe what problem this fixes in the commit log message. I guess some people use shell metacharacters and/or SP in their branch names and this is about that problem?