git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-svnimport: Use separate arguments in the pipe for git-rev-parse

From
Matthias Urlichs <smurf@smurf.noris.de>
Date
Sep 18, 2007, 07:47 UTC
Message-ID
<20070918074753.GQ31176@kiste.smurf.noris.de>
In-Reply-To
<200709171333.48331.danda@osc.co.cr>
Signed-Off-By: Matthias Urlichs <smurf@smurf.noris.de>
---
Please tell me whether that works for you.
Somebody else, preferably its author, can fix git-svn. ;-)
diff --git a/git-svnimport.perl b/git-svnimport.perl
index d3ad5b9..aa5b3b2 100755
--- a/git-svnimport.perl
+++ b/git-svnimport.perl
@@ -633,7 +633,7 @@ sub commit {
 
 	my $rev;
 	if($revision > $opt_s and defined $parent) {
-		open(H,"git-rev-parse --verify $parent |");
+		open(H,'-|',"git-rev-parse","--verify",$parent);
 		$rev = <H>;
 		close(H) or do {
 			print STDERR "$revision: cannot find commit '$parent'!\n";
-- 
1.5.2.5

-- 
Matthias Urlichs   |   {M:U} IT Design @ m-u-it.de   |  smurf@smurf.noris.de
Disclaimer: The quote was selected randomly. Really. | http://smurf.noris.de
 - -
"Could a being create the fifty billion galaxies, each with two hundred
 billion stars, then rejoice in the smell of burning goat flesh?"
                         [Ron Patterson]
Next: Junio C Hamano
Message 1 of 9 in “git-svnimport: Use separate arguments in the pipe for git-rev-parse”
  1. git-svnimport: Use separate arguments in the pipe for git-rev-parseMatthias Urlichs, Sep 18, 2007
  2. Junio C HamanoSep 18, 2007
  3. Matthias UrlichsSep 18, 2007
  4. Dan LibbySep 20, 2007
  5. Matthias UrlichsSep 21, 2007
  6. Junio C HamanoSep 21, 2007
  7. Matthias UrlichsSep 21, 2007
  8. Dan LibbySep 21, 2007
  9. Dan LibbySep 20, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.