Re: [PATCH] git-svnimport: Use separate arguments in the pipe for git-rev-parse
- From
- Dan Libby <danda@osc.co.cr>
- Date
- Sep 21, 2007, 20:21 UTC
- Message-ID
- <200709211421.56587.danda@osc.co.cr>
- In-Reply-To
- <20070921102420.GJ11204@kiste.smurf.noris.de>
Hi,
I saw this, so I haven't run the strace command you mentioned. No need now, right?
I'm no expert on these things, but I'd think that it should be replacing (or escaping) any characters (not just spaces) that are not allowed by git-check-ref-format.
For us, replacing any such characters with _ should work fine.
regards,
On Friday 21 September 2007 04:24, Matthias Urlichs wrote:
Show 15 quoted lines
> Hi, > > Junio C Hamano: > > Matthias Urlichs <smurf@smurf.noris.de> writes: > > >> we do not like 'Cristian new code' as a tag name. > > > > > > Duh? That's a perfectly valid tag name. > > > > Is it? > > > > $ man git-check-ref-format > > Bah, stupid me. You're right, obviously. > > I'll replace them with underscores. :-/
-- Dan Libby Open Source Consulting San Jose, Costa Rica http://osc.co.cr phone: 011 506 223 7382 Fax: 011 506 223 7359