Re: [PATCH] Let "git svn" run "git gc --auto" occasionally
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 20, 2008, 19:17 UTC
- Message-ID
- <7vlk6k8fyp.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20080120093436.GA10924@diana.vm.bytemark.co.uk>
Karl Hasselström <kha@treskal.com> writes:
Show 15 quoted lines
> On 2008-01-19 19:37:37 -0800, Eric Wong wrote: > >> Harvey Harrison <harvey.harrison@gmail.com> wrote: >> >> > I found 100 was a bit too low when doing some large repos, I've >> > been using 1000. I'd argue that --repack=1000 should be done by >> > default. >> >> I've found 100 for repack too low in the past, too, which is why >> repack defaults to 1000 if no number is specified. I think it should >> hold for gc --auto, too. > > OK, I'll change it. But remember, gc --auto doesn't do _anything_ > unless it's deemed necessary, so it should behave much better than > just plain repack. In theory at least.
Careful. I made the same mistake and it had to be corrected with e0cd252eb0ba6453acd64762625b004aa4cc162b.
I think defaulting to --repack=1000 is a sane first step and you guys already have most code for it so that is a very safe thing.
Switching to "gc --auto" can be done early post 1.5.4, right?