[PATCH 1/2] git-svn: Don't call git-repack anymore
- From
Karl Hasselström <kha@treskal.com>
- Date
- Jan 20, 2008, 21:39 UTC
- Message-ID
- <20080120213847.9679.56653.stgit@yoghurt>
- In-Reply-To
- <20080120093436.GA10924@diana.vm.bytemark.co.uk>
In a moment, we'll start calling git-gc --auto instead, since it is a better fit to what we're trying to accomplish.
The command line options are still accepted, but don't have any effect, and we warn the user about that.
Signed-off-by: Karl Hasselström <kha@treskal.com>
---
Is this close enough to what you intended?
git-svn.perl | 14 ++------------ 1 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl index 9f2b587..988d8f6 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -1247,7 +1247,6 @@ use File::Path qw/mkpath/; use File::Copy qw/copy/; use IPC::Open3; -my $_repack_nr; # properties that we do not log: my %SKIP_PROP; BEGIN { @@ -1408,10 +1407,8 @@ sub read_all_remotes { } sub init_vars { - if (defined $_repack) { - $_repack = 1000 if ($_repack <= 0); - $_repack_nr = $_repack; - $_repack_flags ||= '-d'; + if (defined $_repack || defined $_repack_flags) { + warn "Repack options are obsolete; they have no effect.\n"; } } @@ -2151,13 +2148,6 @@ sub do_git_commit { 0, $self->svm_uuid); } print " = $commit ($self->{ref_id})\n"; - if (defined $_repack && (--$_repack_nr == 0)) { - $_repack_nr = $_repack; - # repack doesn't use any arguments with spaces in them, does it? - print "Running git repack $_repack_flags ...\n"; - command_noisy('repack', split(/\s+/, $_repack_flags)); - print "Done repacking\n"; - } return $commit; }