Re: [PATCH] Let "git svn" run "git gc --auto" occasionally

From: Karl Hasselström <kha@treskal.com>
Date: Jan 20, 2008, 09:34 UTC
Message-ID: <20080120093436.GA10924@diana.vm.bytemark.co.uk>
In-Reply-To: <20080120033737.GA7767@soma>

On 2008-01-19 19:37:37 -0800, Eric Wong wrote:

Show 9 quoted lines

> Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > I found 100 was a bit too low when doing some large repos, I've
> > been using 1000. I'd argue that --repack=1000 should be done by
> > default.
>
> I've found 100 for repack too low in the past, too, which is why
> repack defaults to 1000 if no number is specified. I think it should
> hold for gc --auto, too.

OK, I'll change it. But remember, gc --auto doesn't do _anything_ unless it's deemed necessary, so it should behave much better than just plain repack. In theory at least.

> I consider --repack is out-of-date now that we have gc --auto. I'm
> in favor of ripping out repack support in git-svn and just using gc
> --auto.

Will do. What should I do with the repack commadline options? Keep them for backwards compatibility but ignore them?

Show 5 quoted lines

> > How about git gc always gets run at the very end of a git svn
> > fetch?
>
> I'd much prefer that we run gc --auto at the end of every fetch
> instead of doing so randomly for small fetches.

OK, will do. I'll just have to find a good spot to call it from. Hints welcome.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle