git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Added --export option to git-send-email.

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 13, 2008, 22:44 UTC
Message-ID
<7vlk05o14i.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<32541b130807131521w79cbf23m5934678e68312798@mail.gmail.com>
"Avery Pennarun" <apenwarr@gmail.com> writes:
> And it's the MDA's job to munge it, not the MTA, so the
> lines should never be munged while in transit *to* ...
Yeah, you're right.  Sending side should not have any issues like that.

My receiving end (I think fetchmail slurps from my ISP and drops mails in my local mbox, but it's a long time ago I configured my system...) does quote only the "From " at the beginning, which is consistent with the traditional mbox behaviour, so I see one, one, two, three in my local mbox, and zero, one, two, three on gmane news article.

If this additional option claims to produce a mbox, I think:
 (1) quoting only /^From / (not /^>*From/) to be consistent with the
     standard practice is the right thing to do; and
 (2) reading side might need to also pay attention to /^>From /, in case
     somebody feeds an output from this option back to send-email.

However, strictly speaking,(2) may break the standard workflow of generating patches with format-patch and feeding the result to send-email, as format-patch does not do /^From / munging (and it shouldn't). The issue is mostly theoretical --- it only matters if your commit log has a line that begins with ">From ", and people who have worked with e-mail for any nontrivial period have already learned to reword their sentences to avoid lines that begin with "From " (or ">From ", for that matter) anyway.

Previous: Avery PennarunNext: Avery Pennarun
Message 10 of 15 in “Added --export option to git-send-email.”
  1. Added --export option to git-send-email.Eduard - Gabriel Munteanu, Jul 10, 2008
  2. Junio C HamanoJul 11, 2008
  3. Eduard - Gabriel MunteanuJul 11, 2008
  4. Junio C HamanoJul 13, 2008
  5. Avery PennarunJul 13, 2008
  6. Junio C HamanoJul 13, 2008
  7. Avery PennarunJul 13, 2008
  8. Junio C HamanoJul 13, 2008
  9. Avery PennarunJul 13, 2008
  10. Junio C HamanoJul 13, 2008
  11. Avery PennarunJul 13, 2008
  12. Eduard - Gabriel MunteanuJul 13, 2008
  13. Junio C HamanoJul 14, 2008
  14. Avery PennarunJul 14, 2008
  15. Eduard - Gabriel MunteanuJul 14, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.