Re: [PATCH] Added --export option to git-send-email.

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 13, 2008, 21:36 UTC
Message-ID: <7vbq11qxfb.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <32541b130807131432j78e5100dyea20893268321466@mail.gmail.com>

"Avery Pennarun" <apenwarr@gmail.com> writes:

Show 13 quoted lines

> On 7/13/08, Junio C Hamano <gitster@pobox.com> wrote:
>> Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> writes:
>>  > +     } elsif (defined $export_file) {
>>  > +             my $mbox_from = "From $raw_from $date";
>>  > +             $message =~ s/^(>{0,})From/>$1From/m;
>>  > +             print $out "$mbox_from\n$header\n$message";
>>
>> Sorry, but I am scratching my head here.  Shouldn't this "bare From
>>  munging" be like this instead?
>>
>>                 $message =~ s/^From />From /m;
>
> That wouldn't be a reversible operation.

So what? Adding Cc: and stuff send-email does are already irreversible anyway.