From: Junio C Hamano Date: Sun, 13 Jul 2008 22:44:29 GMT Subject: Re: [PATCH] Added --export option to git-send-email. Message-ID: <7vlk05o14i.fsf@gitster.siamese.dyndns.org> In-Reply-To: <32541b130807131521w79cbf23m5934678e68312798@mail.gmail.com> "Avery Pennarun" writes: > And it's the MDA's job to munge it, not the MTA, so the > lines should never be munged while in transit *to* ... Yeah, you're right. Sending side should not have any issues like that. My receiving end (I think fetchmail slurps from my ISP and drops mails in my local mbox, but it's a long time ago I configured my system...) does quote only the "From " at the beginning, which is consistent with the traditional mbox behaviour, so I see one, one, two, three in my local mbox, and zero, one, two, three on gmane news article. If this additional option claims to produce a mbox, I think: (1) quoting only /^From / (not /^>*From/) to be consistent with the standard practice is the right thing to do; and (2) reading side might need to also pay attention to /^>From /, in case somebody feeds an output from this option back to send-email. However, strictly speaking,(2) may break the standard workflow of generating patches with format-patch and feeding the result to send-email, as format-patch does not do /^From / munging (and it shouldn't). The issue is mostly theoretical --- it only matters if your commit log has a line that begins with ">From ", and people who have worked with e-mail for any nontrivial period have already learned to reword their sentences to avoid lines that begin with "From " (or ">From ", for that matter) anyway.