git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH v2] fetch-pack: log(n)-transmission find_common()

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 28, 2008, 03:24 UTC
Message-ID
<7vljw9h061.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20081027192923.6117@nanako3.lavabit.com>
Nanako Shiraishi <nanako3@lavabit.com> writes:
Show 12 quoted lines
> Quoting Thomas Rast <trast@student.ethz.ch>:
>
>> Replaces the existing simple history search with a more sophisticated
>> algorithm:
>> 
>> 1) Walk history with exponentially increasing stride lengths; i.e.,
>>    send the 1st commit, then the 2nd after that, then the 4th after
>>    that, and so on.
>> 
>> 2) Bisect the resulting intervals.
>
> Junio, may I ask what the status of this patch is? I see Nicolas responded and said "I gave this a quick try". Wasn't it a good enough review?

I took the "quick try" more about "first feel in performance" and not "code review concentrating on correctness and trying to catch mistakes".

I like what the patch tries to solve, and the approach it takes to solve it. I haven't had a chance to have a block of time for me to concentrate on this patch to assess where it could go wrong yet.

Previous: Nanako ShiraishiNext: Nicolas Pitre
Message 7 of 13 in “[RFC] log(n)-transmissions common commit handshake”
  1. Thomas RastSep 17, 2008
  2. fetch-pack: log(n)-transmission find_common()Thomas Rast, Sep 17, 2008
  3. fetch-pack: log(n)-transmission find_common()Thomas Rast, Sep 24, 2008
  4. fetch-pack: log(n)-transmission find_common()Thomas Rast, Oct 23, 2008
  5. Nicolas PitreOct 24, 2008
  6. Nanako ShiraishiOct 27, 2008
  7. Junio C HamanoOct 28, 2008
  8. Nicolas PitreOct 28, 2008
  9. Thomas RastOct 28, 2008
  10. 0/2 fetch-pack: log(n)-transmission find_common()Thomas Rast, Dec 6, 2008
  11. 1/2 fetch-pack: rearrange main loopThomas Rast, Dec 6, 2008
  12. 2/2 fetch-pack: log(n)-transmission find_common()Thomas Rast, Dec 6, 2008
  13. Thomas RastSep 18, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.