From: Junio C Hamano Date: Tue, 28 Oct 2008 03:24:22 GMT Subject: Re: [RFC PATCH v2] fetch-pack: log(n)-transmission find_common() Message-ID: <7vljw9h061.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20081027192923.6117@nanako3.lavabit.com> Nanako Shiraishi writes: > Quoting Thomas Rast : > >> Replaces the existing simple history search with a more sophisticated >> algorithm: >> >> 1) Walk history with exponentially increasing stride lengths; i.e., >> send the 1st commit, then the 2nd after that, then the 4th after >> that, and so on. >> >> 2) Bisect the resulting intervals. > > Junio, may I ask what the status of this patch is? I see Nicolas responded and said "I gave this a quick try". Wasn't it a good enough review? I took the "quick try" more about "first feel in performance" and not "code review concentrating on correctness and trying to catch mistakes". I like what the patch tries to solve, and the approach it takes to solve it. I haven't had a chance to have a block of time for me to concentrate on this patch to assess where it could go wrong yet.