Re: [RFC PATCH v2] fetch-pack: log(n)-transmission find_common()

From: Nicolas Pitre <nico@cam.org>
Date: Oct 28, 2008, 14:46 UTC
Message-ID: <alpine.LFD.2.00.0810281034500.13034@xanadu.home>
In-Reply-To: <7vljw9h061.fsf@gitster.siamese.dyndns.org>

On Mon, 27 Oct 2008, Junio C Hamano wrote:

Show 17 quoted lines

> Nanako Shiraishi <nanako3@lavabit.com> writes:
> 
> > Quoting Thomas Rast <trast@student.ethz.ch>:
> >
> >> Replaces the existing simple history search with a more sophisticated
> >> algorithm:
> >> 
> >> 1) Walk history with exponentially increasing stride lengths; i.e.,
> >>    send the 1st commit, then the 2nd after that, then the 4th after
> >>    that, and so on.
> >> 
> >> 2) Bisect the resulting intervals.
> >
> > Junio, may I ask what the status of this patch is? I see Nicolas responded and said "I gave this a quick try". Wasn't it a good enough review?
> 
> I took the "quick try" more about "first feel in performance" and not
> "code review concentrating on correctness and trying to catch mistakes".

Exact.

FWIW, I had to back this patch out from my version as things seemed to fall into an infinite loop of ref negotiation while fetching the Linux kernel repository at some point. Doing a "git fetch -v -v" turned up an endless stream of "got" and "have" lines. I was in a hurry for $work so didn't think of preserving my local refs for reproduction of the problem.

Sorry for not being more helpful. This is some part of git that I know f-all about.

Nicolas