Re: [PATCH 2/8] config: Cleanup config file handling.

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 16, 2009, 01:15 UTC
Message-ID: <7vljs7gp15.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1234688460-9248-2-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> As suggested by Johannes Schindelin.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>

Dscho won't be the only person who will read "git log" output. What was suggested, what convinced you it is a good idea, what goodness would this patch add if I take it?

Show 7 quoted lines

> -			if (git_config(show_all_config, NULL) < 0 &&
> -					file && errno)
> -				die("unable to read config file %s: %s", file,
> -				    strerror(errno));
> +			if (git_config(show_all_config, NULL) < 0)
> +				die("error processing config file(s)");
>  			return 0;

This is the only change with substance in this patch. What difference does it make? Earlier we failed to say "die" with message in some situations, and now we die when git_config() signals any error.

What are the situations in whoich the command misbehaved? The commit log message is where you are expected to explain that.