git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/8] config: Cleanup config file handling.

From
Jeff King <peff@peff.net>
Date
Feb 15, 2009, 20:15 UTC
Message-ID
<20090215201505.GC26779@coredump.intra.peff.net>
In-Reply-To
<1234688460-9248-2-git-send-email-felipe.contreras@gmail.com>
On Sun, Feb 15, 2009 at 11:00:54AM +0200, Felipe Contreras wrote:
> As suggested by Johannes Schindelin.

Thank you for splitting this patch up. I have to admit I was too scared to read the original after seeing the diffstat.

But part of the nice thing about splitting up is that you can write meaningful commit messages for each individual change. Reading this commit message, I don't know what to expect.

Your 1/8, though short, tells me what to expect: a trivial rename. But "clean up config file handling" is quite ambiguous. And after reading the patch, I am left wondering why the filename and errno are not useful as part of the die() message. I think even a single sentence would probably make it clear.

And yes, I know I can look elsewhere in the thread to find the discussion between you and Dscho. But think of the poor "git log" user six months from now.

-Peff
Previous: Felipe ContrerasNext: Junio C Hamano
Message 18 of 19 in “config: Trivial rename in preparation for parseopt.”
  1. 1/8 config: Trivial rename in preparation for parseopt.Felipe Contreras, Feb 15, 2009
  2. 2/8 config: Cleanup config file handling.Felipe Contreras, Feb 15, 2009
  3. 3/8 config: Use parseopt.Felipe Contreras, Feb 15, 2009
  4. 4/8 config: Improve variable 'type' handling.Felipe Contreras, Feb 15, 2009
  5. 5/8 config: Disallow multiple config file locations.Felipe Contreras, Feb 15, 2009
  6. 6/8 config: Don't allow extra arguments for -e or -l.Felipe Contreras, Feb 15, 2009
  7. 7/8 config: Don't return negative exit codes.Felipe Contreras, Feb 15, 2009
  8. 8/8 config: Codestyle cleanups.Felipe Contreras, Feb 15, 2009
  9. Johannes SchindelinFeb 15, 2009
  10. Felipe ContrerasFeb 15, 2009
  11. Felipe ContrerasFeb 15, 2009
  12. Johannes SchindelinFeb 15, 2009
  13. Felipe ContrerasFeb 15, 2009
  14. Felipe ContrerasFeb 15, 2009
  15. Johannes SchindelinFeb 15, 2009
  16. Felipe ContrerasFeb 15, 2009
  17. Felipe ContrerasFeb 15, 2009
  18. Jeff KingFeb 15, 2009
  19. Junio C HamanoFeb 16, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.