git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/8] config: Don't allow extra arguments for -e or -l.

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Feb 15, 2009, 09:00 UTC
Message-ID
<1234688460-9248-6-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1234688460-9248-5-git-send-email-felipe.contreras@gmail.com>
As suggested by Johannes Schindelin.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 builtin-config.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/builtin-config.c b/builtin-config.c
index e744ad8..3463b1c 100644
--- a/builtin-config.c
+++ b/builtin-config.c
@@ -375,10 +375,12 @@ int cmd_config(int argc, const char **argv, const char *unused_prefix)
 		}
 
 	if (actions & ACTION_LIST) {
+		check_argc(argc, 0, 0);
 		if (git_config(show_all_config, NULL) < 0)
 			die("error processing config file(s)");
 	}
 	else if (actions & ACTION_EDIT) {
+		check_argc(argc, 0, 0);
 		const char *config_filename;
 		if (config_exclusive_filename)
 			config_filename = config_exclusive_filename;
-- 
1.6.1.3
Previous: Felipe ContrerasNext: Felipe Contreras
Message 6 of 19 in “config: Trivial rename in preparation for parseopt.”
  1. 1/8 config: Trivial rename in preparation for parseopt.Felipe Contreras, Feb 15, 2009
  2. 2/8 config: Cleanup config file handling.Felipe Contreras, Feb 15, 2009
  3. 3/8 config: Use parseopt.Felipe Contreras, Feb 15, 2009
  4. 4/8 config: Improve variable 'type' handling.Felipe Contreras, Feb 15, 2009
  5. 5/8 config: Disallow multiple config file locations.Felipe Contreras, Feb 15, 2009
  6. 6/8 config: Don't allow extra arguments for -e or -l.Felipe Contreras, Feb 15, 2009
  7. 7/8 config: Don't return negative exit codes.Felipe Contreras, Feb 15, 2009
  8. 8/8 config: Codestyle cleanups.Felipe Contreras, Feb 15, 2009
  9. Johannes SchindelinFeb 15, 2009
  10. Felipe ContrerasFeb 15, 2009
  11. Felipe ContrerasFeb 15, 2009
  12. Johannes SchindelinFeb 15, 2009
  13. Felipe ContrerasFeb 15, 2009
  14. Felipe ContrerasFeb 15, 2009
  15. Johannes SchindelinFeb 15, 2009
  16. Felipe ContrerasFeb 15, 2009
  17. Felipe ContrerasFeb 15, 2009
  18. Jeff KingFeb 15, 2009
  19. Junio C HamanoFeb 16, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.