Re: [PATCH] log: respect log.shownotes variable

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 7, 2010, 21:53 UTC
Message-ID: <7vljczapzt.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100407204536.GA32382@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 5 quoted lines

> I guess an alternate solution would be for me to store them in some
> other ref, and then use --show-notes=email when I do want to see them
> (instead of just --show-notes, as I would do with this patch). But I
> still wonder if log.shownotes is a sensible addition, just for the sake
> of completeness.

My gut feeling is that people who do have notes in the default namespace (or the ones in notes.displayRef) do want to see them _all the time_. Otherwise they'd put such notes in namespaces that are not shown by default, and view them on demand, no?

But then there is a bigger question: what kind of notes would you want to always see as part of "git log" output? My answer to that question for my personal workflow (both dayjob and here) so far has been "none", and that is exactly the reason why my "applied from this message" notes live in notes/am namespace and I have nothing in the default notes namespace.

If the answer is "none" for everybody, we should disable showing notes in any command unless the user explicitly asks with either the --show-notes command line option or the notes.displayRef and perhaps log.shownotes configuration variables.