Re: [PATCH] log: respect log.shownotes variable
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 8, 2010, 16:55 UTC
- Message-ID
- <7v39z57ujt.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <201004081812.50112.trast@student.ethz.ch>
Thomas Rast <trast@student.ethz.ch> writes:
> Looks useful to me, and the patch looks obviously correct.
It looked obviously correct and "because we can" not "because we need" to me.
> I think it is a useful addition, *especially* in the case where the > configuration departs from the default. Typing --show-notes=email > --show-notes=commits just to avoid showing a third set of notes in > refs/notes/bulky will get old fairly quickly...
I initially thought so until I realized that notes.displayRef is already there. But you are the one who did 894a9d3 (Support showing notes from more than one notes tree, 2010-03-12) to add that feature, so I suspect I forgot something while reaching my conclusion in [*1*].
[reference]
*1* Message-ID: <7vljczapzt.fsf@alter.siamese.dyndns.org>
$gmane/144286