Re: [PATCH] log: respect log.shownotes variable

From: Jeff King <peff@peff.net>
Date: Apr 8, 2010, 07:05 UTC
Message-ID: <20100408070526.GH30473@coredump.intra.peff.net>
In-Reply-To: <7vljczapzt.fsf@alter.siamese.dyndns.org>

On Wed, Apr 07, 2010 at 02:53:42PM -0700, Junio C Hamano wrote:

> My gut feeling is that people who do have notes in the default namespace
> (or the ones in notes.displayRef) do want to see them _all the time_.
> Otherwise they'd put such notes in namespaces that are not shown by
> default, and view them on demand, no?

I dunno. I don't have any notes I've written, so I just stuck Thomas' in refs/notes/commit. In retrospect, that was probably dumb, because it conflicts with any notes I would write.

Show 5 quoted lines

> But then there is a bigger question: what kind of notes would you want to
> always see as part of "git log" output?  My answer to that question for my
> personal workflow (both dayjob and here) so far has been "none", and that
> is exactly the reason why my "applied from this message" notes live in
> notes/am namespace and I have nothing in the default notes namespace.

Yeah, thinking on it more, that is much better. I now have:

  [remote "trast"]
	  url = git://repo.or.cz/git/trast.git
	  fetch = +refs/heads/notes/*:refs/notes/am/*

which makes more sense (and I was happy to see he has kept updating them. My copy was quite stale).

So let's ignore log.shownotes for now, and encourage people to manage their notes better. When we see more how people are using notes, we may want it, but let's wait until then.

-Peff