git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/7] Improved infrastructure for refname normalization

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 13, 2011, 17:43 UTC
Message-ID
<7vlitswd5u.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4E6ED90D.1090704@alum.mit.edu>
Michael Haggerty <mhagger@alum.mit.edu> writes:
Show 23 quoted lines
> Consistency of the UI should be the goal.  Supporting unnormalized
> refnames some places, but not others, will just confuse and frustrate
> users.
> ...
> So I propose the following:
>
> * Institute a policy that refnames in the UI must always be normalized
>
> * On a best-effort basis, emit errors whenever unnormalized refnames are
> encountered
>
> * Continue to support "git check-ref-format --print", which script
> writers can use to normalize refnames if they need to.
>
> The only disadvantage of a stricter policy is that some of today's
> sloppy scripts, which today might sometimes work (but not reliably),
> break in a pretty obvious way that can be fixed with a single call to
> "git check-ref-format --print".
>
> I'd rather get beyond this swamp and start working on the hierarchical
> reference cache, which will bring some real benefits.  (The hierarchical
> reference cache requires some sanity in refname handling, which is why I
> got into this mess in the first place.)
Both the analysis and theproposal I find very sane and sensible. Thanks.
Previous: Michael Haggerty
Message 13 of 13 in “Improved infrastructure for refname normalization”
  1. 0/7 Improved infrastructure for refname normalizationMichael Haggerty, Sep 10, 2011
  2. 1/7 t1402: add some more testsMichael Haggerty, Sep 10, 2011
  3. 2/7 Change bad_ref_char() to return a boolean valueMichael Haggerty, Sep 10, 2011
  4. 3/7 git check-ref-format: add options --allow-onelevel and --refspec-patternMichael Haggerty, Sep 10, 2011
  5. 4/7 Change check_ref_format() to take a flags argumentMichael Haggerty, Sep 10, 2011
  6. 5/7 Add a library function normalize_refname()Michael Haggerty, Sep 10, 2011
  7. 6/7 Do not allow ".lock" at the end of any refname componentMichael Haggerty, Sep 10, 2011
  8. 7/7 Add tools to avoid the use of unnormalized refnames.Michael Haggerty, Sep 10, 2011
  9. Junio C HamanoSep 12, 2011
  10. Michael HaggertySep 12, 2011
  11. Junio C HamanoSep 12, 2011
  12. Michael HaggertySep 13, 2011
  13. Junio C HamanoSep 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.