Re: [PATCH] Allow generating a non-default set of documentation

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 7, 2012, 23:25 UTC
Message-ID: <7vlifhooe1.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20121007231156.GD3490@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 12 quoted lines

> On Sun, Oct 07, 2012 at 07:07:03PM -0400, Jeff King wrote:
>
>> Would it make sense to pull all of our platform-specific tweaks out into
>> a config.mak.platform (right before config.mak.autogen)? That would be
>> less surprising for cases like this, and I think it would make the
>> Makefile a lot more readable.
>
> Something like the patch below. Note that you could then base even more
> decisions on the existing DEFAULT_HELP_FORMAT that is already in the
> Makefile (and after my patch, in config.mak.defaults). For example, when
> it is set to html, make both the default build and install targets in
> Documentation/Makefile do html instead of man.

Yeah, modulo that the "defaults" is tracked and does not have to have the dash before "include" (it is an error if it is missing, no?). It may want to be named with s/defaults/autodetect/, though.

Show 10 quoted lines

> diff --git a/Makefile b/Makefile
> index e3e3cd5..c00fd32 100644
> --- a/Makefile
> +++ b/Makefile
> ...
> -endif
> -
> +-include config.mak.defaults
>  -include config.mak.autogen
>  -include config.mak