git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Allow generating a non-default set of documentation

From
Jeff King <peff@peff.net>
Date
Oct 7, 2012, 23:01 UTC
Message-ID
<20121007230102.GB3490@sigill.intra.peff.net>
In-Reply-To
<7vsj9poq8v.fsf@alter.siamese.dyndns.org>
On Sun, Oct 07, 2012 at 03:45:52PM -0700, Junio C Hamano wrote:
Show 5 quoted lines
> So here is a proposed update based on your idea, to be squashed on
> top (i.e. the change to the top-level Makefile in the posted patch
> is not reverted).
> 
> Does it make sense?

The change to Documentation/Makefile makes sense, but what then is the point of the second half of this hunk from your original:

@@ -2468,10 +2476,10 @@ $(XDIFF_LIB): $(XDIFF_OBJS)
 $(VCSSVN_LIB): $(VCSSVN_OBJS)
 	$(QUIET_AR)$(RM) $@ && $(AR) rcs $@ $(VCSSVN_OBJS)
 
-export DEFAULT_EDITOR DEFAULT_PAGER
+export DEFAULT_EDITOR DEFAULT_PAGER DEFAULT_DOC_TARGET
 
 doc:
-	$(MAKE) -C Documentation all
+	$(MAKE) -C Documentation $(DEFAULT_DOC_TARGET)
 
 man:
 	$(MAKE) -C Documentation man

We know that "all" is simply a redirect to DEFAULT_DOC_TARGET internally
within the documentation Makefile, and we know that it is propagated by
the export line above.  I do not think it creates the wrong behavior,
but it is unnecessary, and omitting a target at all demonstrates to a
reader how they can get the same behavior from within Documentation
(namely by running just "make").

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 12 in “Allow generating a non-default set of documentation”
  1. Allow generating a non-default set of documentationJunio C Hamano, Oct 7, 2012
  2. Jeff KingOct 7, 2012
  3. Junio C HamanoOct 7, 2012
  4. Junio C HamanoOct 7, 2012
  5. Jeff KingOct 7, 2012
  6. Junio C HamanoOct 7, 2012
  7. Jeff KingOct 7, 2012
  8. Jeff KingOct 7, 2012
  9. Junio C HamanoOct 7, 2012
  10. Jeff KingOct 7, 2012
  11. Junio C HamanoOct 7, 2012
  12. Junio C HamanoOct 8, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.