Re: [PATCH] Allow generating a non-default set of documentation
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 7, 2012, 23:44 UTC
- Message-ID
- <7vhaq5onig.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20121007232942.GA5685@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 23 quoted lines
> On Sun, Oct 07, 2012 at 04:25:58PM -0700, Junio C Hamano wrote: > >> Yeah, modulo that the "defaults" is tracked and does not have to >> have the dash before "include" (it is an error if it is missing, >> no?). It may want to be named with s/defaults/autodetect/, though. >> >> > diff --git a/Makefile b/Makefile >> > index e3e3cd5..c00fd32 100644 >> > --- a/Makefile >> > +++ b/Makefile >> > ... >> > -endif >> > - >> > +-include config.mak.defaults >> > -include config.mak.autogen >> > -include config.mak > > Yeah, sorry, mindless copying on my part from the lines below. It > clearly should not have the "-". > > I'm fine with something besides "defaults". I meant it to be "these are > the config defaults before you tweak them", but yeah, it is more like > "these are the config options we picked up from uname".
Let's put this on hold in the "possibly a good direction to go in" pile, and defer it to post 1.8.0; I haven't even looked at (and do not plan to before the release) these "auto-detect" bits are all safe to be included in Makefiles in subdirectories.