Re: [PATCH v4 00/12] Wildmatch v4
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 11, 2012, 16:09 UTC
- Message-ID
- <7vlifd7zz3.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <CACsJy8B2JJmUbjAauMwbg95fCvPdUYqy4CKZp3ac44XHoh1NLQ@mail.gmail.com>
Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
Show 34 quoted lines
> On Thu, Oct 11, 2012 at 11:33 AM, Junio C Hamano <gitster@pobox.com> wrote: >> Junio C Hamano <gitster@pobox.com> writes: >> >>> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes: >>> >>>> Really small updates. I did not want to resend it this soon but this >>>> may fix the compile errors for Junio. >> >> t3070 seems to break TAP, >> >> *** prove *** >> t3070-wildmatch.sh .. Failed 1/151 subtests >> >> Test Summary Report >> ------------------- >> t3070-wildmatch.sh (Wstat: 0 Tests: 150 Failed: 0) >> Parse errors: Tests out of sequence. Found (76) but expected (75) >> Tests out of sequence. Found (77) but expected (76) >> Tests out of sequence. Found (78) but expected (77) >> Tests out of sequence. Found (79) but expected (78) >> Tests out of sequence. Found (80) but expected (79) >> Displayed the first 5 of 77 TAP syntax errors. >> >> This probably is due to this part of the output: >> >> ok 72 - wildmatch 1 1 [ab] [\[:]ab] >> ok 73 - wildmatch 1 1 ?a?b \??\?b >> ok 74 - wildmatch 1 1 abc ^G^Hok 75 - wildmatch 0 0 foo >> ok 76 - wildmatch 1 0 foo/bar/baz/to **/t[o] >> ok 77 - wildmatch 1 1 a1B [[:alpha:]][[:digit:]][[:upper:]] >> > > It seems to prove fine here with perl 5.12.3, Test-Harness-3.230, > bash-4.0_p38. What version do you use?
I seem to have Perl 5.10.1, Test::Harness 3.17, Dash 0.5.5.1. But as you can see above, what is _fed_ to the Perl-side is broken (notice the concatenation at the end of "ok 74"), so I do not think versions of Perl-side matters.
I suspect that this is the immediate culprit:
match 1 1 'abc' '\a\b\c'
The symptom looks like that somebody is interpreting \a as BEL, \b as backspace, etc. when showing the "ok ..." line, no?