git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 04/12] wildmatch: remove unnecessary functions

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Oct 10, 2012, 15:38 UTC
Message-ID
<50759675.1070108@alum.mit.edu>
In-Reply-To
<1349865651-31889-5-git-send-email-pclouds@gmail.com>
On 10/10/2012 12:40 PM, Nguyễn Thái Ngọc Duy wrote:
Show 25 quoted lines
> 
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  wildmatch.c | 161 ++++--------------------------------------------------------
>  wildmatch.h |   2 -
>  2 files changed, 9 insertions(+), 154 deletions(-)
> 
> diff --git a/wildmatch.c b/wildmatch.c
> index f3a1731..71dba76 100644
> --- a/wildmatch.c
> +++ b/wildmatch.c
> @@ -53,33 +53,19 @@
>  #define ISUPPER(c) (ISASCII(c) && isupper(c))
>  #define ISXDIGIT(c) (ISASCII(c) && isxdigit(c))
>  
> -#ifdef WILD_TEST_ITERATIONS
> -int wildmatch_iteration_count;
> -#endif
> -
>  static int force_lower_case = 0;
>  
>  /* Match pattern "p" against the a virtually-joined string consisting
>   * of "text" and any strings in array "a". */
> -static int dowild(const uchar *p, const uchar *text, const uchar*const *a)
> +static int dowild(const uchar *p, const uchar *text)
The comment still refers to array "a".
Michael
-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 6 of 28 in “Wildmatch v4”
  1. 00/12 Wildmatch v4Nguyễn Thái Ngọc Duy, Oct 10, 2012
  2. 01/12 ctype: make sane_ctype[] const arrayNguyễn Thái Ngọc Duy, Oct 10, 2012
  3. 02/12 ctype: support iscntrl, ispunct, isxdigit and isprintNguyễn Thái Ngọc Duy, Oct 10, 2012
  4. 03/12 Import wildmatch from rsyncNguyễn Thái Ngọc Duy, Oct 10, 2012
  5. 04/12 wildmatch: remove unnecessary functionsNguyễn Thái Ngọc Duy, Oct 10, 2012
  6. Michael HaggertyOct 10, 2012
  7. 05/12 Integrate wildmatch to gitNguyễn Thái Ngọc Duy, Oct 10, 2012
  8. Johannes SixtOct 12, 2012
  9. Junio C HamanoOct 12, 2012
  10. 06/12 wildmatch: make wildmatch's return value compatible with fnmatchNguyễn Thái Ngọc Duy, Oct 10, 2012
  11. 07/12 wildmatch: remove static variable force_lower_caseNguyễn Thái Ngọc Duy, Oct 10, 2012
  12. 08/12 wildmatch: fix case-insensitive matchingNguyễn Thái Ngọc Duy, Oct 10, 2012
  13. 09/12 wildmatch: adjust "**" behaviorNguyễn Thái Ngọc Duy, Oct 10, 2012
  14. 10/12 wildmatch: make /**/ match zero or more directoriesNguyễn Thái Ngọc Duy, Oct 10, 2012
  15. 11/12 Support "**" wildcard in .gitignore and .gitattributesNguyễn Thái Ngọc Duy, Oct 10, 2012
  16. 12/12 t3070: disable two fnmatch tests that have different results on different libcNguyễn Thái Ngọc Duy, Oct 10, 2012
  17. Johannes SixtOct 12, 2012
  18. Nguyen Thai Ngoc DuyOct 12, 2012
  19. Junio C HamanoOct 10, 2012
  20. Junio C HamanoOct 11, 2012
  21. Nguyen Thai Ngoc DuyOct 11, 2012
  22. Junio C HamanoOct 11, 2012
  23. Junio C HamanoOct 11, 2012
  24. Junio C HamanoOct 11, 2012
  25. Torsten BögershausenOct 12, 2012
  26. Junio C HamanoOct 12, 2012
  27. Torsten BögershausenOct 12, 2012
  28. Nguyen Thai Ngoc DuyOct 13, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.