Re: [PATCH v4 00/12] Wildmatch v4
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 11, 2012, 23:50 UTC
- Message-ID
- <7vipag601h.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <7vvceh6imi.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 17 quoted lines
> Ahh, it must be this bits from t/test-lib.sh
>
> t/test-lib.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git i/t/test-lib.sh w/t/test-lib.sh
> index 514282c..489bc80 100644
> --- i/t/test-lib.sh
> +++ w/t/test-lib.sh
> @@ -230,7 +230,7 @@ else
> say_color() {
> test -z "$1" && test -n "$quiet" && return
> shift
> - echo "$*"
> + printf "%s\n" "$*"
> }
> fiI'll queue this fix separately before your series on 'pu'.
-- >8 -- Subject: [PATCH] test-lib: Fix say_color () not to interpret \a\b\c in the message
When running with color disabled (e.g. under prove to produce TAP output), say_color() helper function is defined to use echo to show the message. With a message that ends with "\c", echo is allowed to interpret it as "Do not end the line with LF".
Use printf "%s\n" to emit the message literally.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- t/test-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh index c0d04c4..280b3aa 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -169,7 +169,7 @@ else say_color() { test -z "$1" && test -n "$quiet" && return shift - echo "$*" + printf "%s\n" "$*" } fi
-- 1.8.0.rc1.82.ga68bb49