Re: [PATCH] Spell __attribute__ correctly in cache.h.
- From
Junio C Hamano <junkio@cox.net>
- Date
- Aug 19, 2005, 09:04 UTC
- Message-ID
- <7vk6ii1emh.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <812.1124424608@lotus.CS.Berkeley.EDU>
Jason Riedy <ejr@cs.berkeley.edu> writes:
> Sun's cc doesn't know __attribute__.
It turns out that your patch breaks GCC build (#ifndef __attribute__ is true there, and it should be---what it does cannot be done in preprocessor alone). I am going to work it around like this. Could you try it with Sun cc please?
---
diff --git a/cache.h b/cache.h --- a/cache.h +++ b/cache.h @@ -38,11 +38,10 @@ #define NORETURN __attribute__((__noreturn__)) #else #define NORETURN -#endif - #ifndef __attribute__ #define __attribute__(x) #endif +#endif /* * Intensive research over the course of many years has shown that