Re: [PATCH] Spell __attribute__ correctly in cache.h.
- From
Junio C Hamano <junkio@cox.net>
- Date
- Aug 19, 2005, 19:53 UTC
- Message-ID
- <7v64u1ya7c.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <4091.1124463516@lotus.CS.Berkeley.EDU>
Jason Riedy <ejr@EECS.Berkeley.EDU> writes:
> And Junio C Hamano writes: > - It turns out that your patch breaks GCC build > > Whoops, sorry. Your fix works with Sun's cc.
Thanks.
Show 6 quoted lines
> BTW, how would people feel about replacing the > setenv() and unsetenv() calls with the older putenv()? > The Solaris version I have to work on doesn't have > the nicer functions (and I'm not an admin). I have > to check that the unsetenv() in git-fsck-cache.c works > correctly as a putenv before I send along a patch.
No comment on this one at this moment until I do my own digging a bit.
> There's also the issue that /bin/sh isn't bash, but an > installation-time helper script can fix that.
My personal preference is to rewrite parts that are easily unbashified first before going that route, but I suspect that it would end up being the best practical solution to simply admit that we depend on bash, start our scripts with "#!/bin/bash", and rewrite them "#!/usr/local/bin/bash" upon installation; modulo that it may be a stupid and ugly workaround.