git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Spell __attribute__ correctly in cache.h.

From
Jason Riedy <ejr@eecs.berkeley.edu>
Date
Aug 19, 2005, 14:58 UTC
Message-ID
<4091.1124463516@lotus.CS.Berkeley.EDU>
In-Reply-To
<7vk6ii1emh.fsf@assigned-by-dhcp.cox.net>
And Junio C Hamano writes:
 - It turns out that your patch breaks GCC build 
Whoops, sorry.  Your fix works with Sun's cc.

BTW, how would people feel about replacing the setenv() and unsetenv() calls with the older putenv()? The Solaris version I have to work on doesn't have the nicer functions (and I'm not an admin). I have to check that the unsetenv() in git-fsck-cache.c works correctly as a putenv before I send along a patch. There's also the issue that /bin/sh isn't bash, but an installation-time helper script can fix that.

Jason
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 13 in “Spell __attribute__ correctly in cache.h.”
  1. Spell __attribute__ correctly in cache.h.Jason Riedy, Aug 19, 2005
  2. Junio C HamanoAug 19, 2005
  3. Jason RiedyAug 19, 2005
  4. Junio C HamanoAug 19, 2005
  5. Jason RiedyAug 23, 2005
  6. Junio C HamanoAug 28, 2005
  7. Jason RiedyAug 28, 2005
  8. Linus TorvaldsAug 28, 2005
  9. Antti-Juhani KaijanahoAug 28, 2005
  10. Linus TorvaldsAug 28, 2005
  11. Martijn KuipersAug 29, 2005
  12. Antti-Juhani KaijanahoAug 29, 2005
  13. Martijn KuipersAug 29, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.