Re: [PATCH v3 2/4] git-submodule: New subcommand 'summary' (2) - show commit summary
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 5, 2008, 23:57 UTC
- Message-ID
- <7vk5kgiv0v.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1204481710-29791-2-git-send-email-pkufranky@gmail.com>
Ping Yin <pkufranky@gmail.com> writes:
Show 14 quoted lines
> Example: commit summary for modified submodules sm1-sm5. > -------------------------------------------- > $ git submodule summary > # Submodules modifiled: sm1 sm2 sm3 sm4 sm5 > # > # * sm1 354cd45...3f751e5: > # <one line message for C > # <one line message for B > # >one line message for D > # >one line message for E > ... > --A-->B-->C (in src:354cd45) > \ > -->D-->E (in dst:3f751e5)
The ordering of the commits in the above list is (1) unnatural and (2) does not match what you would see with "log --left-right --topo-order C...E".
I do not think "it shows the path to move from C to E" justifies it. If you are showing them as a linear list (which you cannot avoid if you are doing a sequence of one-line description), you cannot represent such a "path" anyway (think "merge"). If an appliance project rebinds kernel/ path from a project based on linux-2.4 to linux-2.6 while upgrading, such a "path" may not even exist.
I think I've already said the above to your initial round. It is a bit dissapointing to see none of the comments were addressed and makes me wonder if I have wasted my time reviewing them again.
It also is unnerving that newly added and deleted submodule results in the full history display. It would be assuring to be able to see and verify what the top commit is (or was in "deleted" case) while you are commiting, but I do not see a reason to show more than that.
I do not think "then set the limit to 1" is a valid answer to that concern. Wanting to see a dozen top commits in each for a modified submodule would be sensible (and 3/4 may implement such a limit) but even then showing dozen top commits for new/deleted at the same time would be just an added noise. Is it really necessary to show more than the top for new/deleted case?