Re: [PATCH v3 3/4] git-submodule: New subcommand 'summary' (3) - limit summary size

From: Ping Yin <pkufranky@gmail.com>
Date: Mar 6, 2008, 02:24 UTC
Message-ID: <46dff0320803051824t75f39524uda9bc864a9fe4435@mail.gmail.com>
In-Reply-To: <7v7iggitsd.fsf@gitster.siamese.dyndns.org>

On Thu, Mar 6, 2008 at 8:24 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> Ping Yin <pkufranky@gmail.com> writes:
>
>  > This patch teaches git-submodule an option '--summary-limit|-n <number>'
>  > to limit number of commits in total for the summary. Number 0 will disable
>  > summary and minus number means unlimted (the default).
>
>  I really doubt showing the bottom one specially makes sense.
>
>  Why not just read from
>
>         git log '--pretty=%m %h %s' --left-right --topo-order A...B
>
>  and show N top commits from each?

I don't have strong point about this. This one sounds fine to me and will make my patch much simpler.

Show 5 quoted lines

>
>  I've already said that I do not think applying the same limit to
>  new/deleted/modified cases makes sense, so commenting on this
>  part might be a moot point, though.
>

Howabout a new option to limit the added/deleted case which default to 1 or 2?

-- 
Ping Yin