Re: [PATCH v3 2/4] git-submodule: New subcommand 'summary' (2) - show commit summary

From: Ping Yin <pkufranky@gmail.com>
Date: Mar 6, 2008, 05:56 UTC
Message-ID: <46dff0320803052156u374d70c1i45f7789233beb32c@mail.gmail.com>
In-Reply-To: <7v3ar4lcgf.fsf@gitster.siamese.dyndns.org>

On Thu, Mar 6, 2008 at 12:10 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 17 quoted lines

> "Ping Yin" <pkufranky@gmail.com> writes:
>
>  > ... I think showing 2 (the head and tail one) should make more sense
>
> > since the head one would be "Initial add ..." in many cases which
>  > doesn't make much sense for the user.
>
>  Why would you want to see the bottom one?  I still don't understand.
>
>  And I do not mean this as a rhetorical question.  I am here to learn and
>  I would like to make sure that I do not make a suggestion based on wrong
>  understanding of what the user wants to see.
>
>  I probably am lacking imagination to think of a good use scenario that
>  showing the bottom one would be useful to the user, and you as the author
>  of this patch must thought about what the user want much more than me.
>

Showing the bottom one can give the user an impression where the submodules goes at first glance if the user is familiar with the developing progress of the submodule.

However, i don't have very strong point on this and just think it seems good when i type 'git log' (i have make the summary go into the commit message)

-- 
Ping Yin