git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] log: fix --max-count when used together with -S or -G

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 9, 2011, 22:27 UTC
Message-ID
<7vk4g87wvf.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20110309213824.GA4400@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> Hmm. Is this papering over a bigger problem,...

It is not very obvious to me if redefining the semantics of filtering done by diff (the current definition is it is purely an output phase thing) is necessarily a good thing. I agree that the interaction between the output phase filtering and pruning done by the revision walker machinery is a fine topic to discuss.

But Matthieu's patch is not papering over anything but is a real fix within the context of the current architecture.

Previous: Matthieu MoyNext: Jeff King
Message 7 of 8 in “BUG? git log -Sfoo --max-count=N”
  1. Óscar FuentesMar 6, 2011
  2. Re: BUG? git log -Sfoo --max-count=NMatthieu Moy, Mar 7, 2011
  3. Junio C HamanoMar 8, 2011
  4. log: fix --max-count when used together with -S or -GMatthieu Moy, Mar 9, 2011
  5. Jeff KingMar 9, 2011
  6. Matthieu MoyMar 9, 2011
  7. Junio C HamanoMar 9, 2011
  8. Jeff KingMar 10, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.