git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] log: fix --max-count when used together with -S or -G

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Mar 9, 2011, 21:49 UTC
Message-ID
<vpqk4g8hsmf.fsf@bauges.imag.fr>
In-Reply-To
<20110309213824.GA4400@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> So it's definitely a much deeper topic than your small patch. Which
> maybe means we should apply your patch now as a band-aid and hope for a
> better solution in the long term. I dunno.

I'm too lazy/don't have time to do an in-depth fix. It doesn't seem crazy to apply the patch, since it fixes the common case, and adds tests for it, but I don't care personnaly about the feature/bug, so I won't fight if it's rejected. I can resend with a more explicit comment in the code saying it would deserve a better fix if someone cares.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Jeff KingNext: Junio C Hamano
Message 6 of 8 in “BUG? git log -Sfoo --max-count=N”
  1. Óscar FuentesMar 6, 2011
  2. Re: BUG? git log -Sfoo --max-count=NMatthieu Moy, Mar 7, 2011
  3. Junio C HamanoMar 8, 2011
  4. log: fix --max-count when used together with -S or -GMatthieu Moy, Mar 9, 2011
  5. Jeff KingMar 9, 2011
  6. Matthieu MoyMar 9, 2011
  7. Junio C HamanoMar 9, 2011
  8. Jeff KingMar 10, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.