From: Junio C Hamano Date: Wed, 09 Mar 2011 22:27:32 GMT Subject: Re: [PATCH] log: fix --max-count when used together with -S or -G Message-ID: <7vk4g87wvf.fsf@alter.siamese.dyndns.org> In-Reply-To: <20110309213824.GA4400@sigill.intra.peff.net> Jeff King writes: > Hmm. Is this papering over a bigger problem,... It is not very obvious to me if redefining the semantics of filtering done by diff (the current definition is it is purely an output phase thing) is necessarily a good thing. I agree that the interaction between the output phase filtering and pruning done by the revision walker machinery is a fine topic to discuss. But Matthieu's patch is not papering over anything but is a real fix within the context of the current architecture.