git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] make-static: master

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 15, 2011, 04:29 UTC
Message-ID
<7vk49aqvgd.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CALkWK0=TovazpdOvS_va7L0Fv=HcAc9x1-f+LEH_mXgKa-wCQg@mail.gmail.com>
Ramkumar Ramachandra <artagnon@gmail.com> writes:
Show 11 quoted lines
> Junio C Hamano writes:
>> Many symbols that are exported to the global scope do not have to be.
>>
>> Signed-off-by: Junio C Hamano <junio@pobox.com>
>> ---
>>    To be applied on top of 3793ac5 (RelNotes/1.7.7: minor fixes, 2011-09-07)
>> [...]
>
> Awesome!  I've seen many similar "make-static" patches come up on the
> list, but turned down due to code churn issues.  I'm happy to finally
> see it being merged.
Not so fast.

We just got a new series from Brandon Casey that adds a new caller to one of the functions that were unused outside a file. Seeing that this happens even inside a relative calm of pre-release feature and code freeze, realize why we call such a change a "churn" and try to avoid it, and imagine how much damage it would have caused if more topics were actively being updated.

You should learn to tame your enthusiasm ;-)
Previous: Ramkumar RamachandraNext: Ramsay Jones
Message 6 of 14 in “sparse: Fix some "symbol not declared" warnings”
  1. 1/3 sparse: Fix some "symbol not declared" warningsRamsay Jones, Sep 11, 2011
  2. Junio C HamanoSep 11, 2011
  3. Junio C HamanoSep 12, 2011
  4. 1/3 make-static: masterJunio C Hamano, Sep 11, 2011
  5. Ramkumar RamachandraSep 12, 2011
  6. Junio C HamanoSep 15, 2011
  7. Ramsay JonesSep 13, 2011
  8. Junio C HamanoSep 13, 2011
  9. Johannes SixtSep 14, 2011
  10. Junio C HamanoSep 14, 2011
  11. Junio C HamanoSep 14, 2011
  12. Thomas RastSep 14, 2011
  13. 2/3 make-static: nextJunio C Hamano, Sep 11, 2011
  14. 3/3 make-static: puJunio C Hamano, Sep 11, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.