From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 15 Sep 2011 04:29:54 GMT
Subject: Re: [PATCH 1/3] make-static: master
Message-ID: <7vk49aqvgd.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CALkWK0=TovazpdOvS_va7L0Fv=HcAc9x1-f+LEH_mXgKa-wCQg@mail.gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

> Junio C Hamano writes:
>> Many symbols that are exported to the global scope do not have to be.
>>
>> Signed-off-by: Junio C Hamano <junio@pobox.com>
>> ---
>>    To be applied on top of 3793ac5 (RelNotes/1.7.7: minor fixes, 2011-09-07)
>> [...]
>
> Awesome!  I've seen many similar "make-static" patches come up on the
> list, but turned down due to code churn issues.  I'm happy to finally
> see it being merged.

Not so fast.

We just got a new series from Brandon Casey that adds a new caller to one
of the functions that were unused outside a file. Seeing that this happens
even inside a relative calm of pre-release feature and code freeze,
realize why we call such a change a "churn" and try to avoid it, and
imagine how much damage it would have caused if more topics were actively
being updated.

You should learn to tame your enthusiasm ;-)