Re: [PATCH 1/3] make-static: master
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Sep 12, 2011, 06:14 UTC
- Message-ID
- <CALkWK0=TovazpdOvS_va7L0Fv=HcAc9x1-f+LEH_mXgKa-wCQg@mail.gmail.com>
- In-Reply-To
- <7vhb4in4j7.fsf@alter.siamese.dyndns.org>
Hi Junio,
Junio C Hamano writes:
Show 6 quoted lines
> Many symbols that are exported to the global scope do not have to be. > > Signed-off-by: Junio C Hamano <junio@pobox.com> > --- > * To be applied on top of 3793ac5 (RelNotes/1.7.7: minor fixes, 2011-09-07) > [...]
Awesome! I've seen many similar "make-static" patches come up on the list, but turned down due to code churn issues. I'm happy to finally see it being merged. What does this mean: should we try to get such things merged immediately after a release? On a related note: I'd also like to know if we can do anything about restructuring the source tree (moving files around, renaming etc).
Minor nit: I can see commits with "Author: Junio C Hamano <gitster@pobox.com>", and "Signed-off-by: Junio C Hamano <junio@pobox.com>" on both 'pu' and 'next'. They seem to be different people at first glance :)
Thanks.
-- Ram