Re: [PATCH] gitweb: snapshot cleanups & support for offering multiple formats
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 11, 2007, 21:26 UTC
- Message-ID
- <7vir8q4opc.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <200707111755.50018.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 12 quoted lines
> I'm not sure if we want to store whole 'application/x-gzip' or only
> 'x-gzip' part of mime type, and if we want to store compressor as
> '| gzip' or simply as 'gzip'.
>
>> This however will break people's existing gitweb configuration,
>> so if we were to do this it should be post 1.5.3, I would say.
>
> This would break not only existing _gitweb_ configuration (when
> gitweb admin installs new gitweb it isn't that hard to correct
> gitweb config), but also git _repositories_ config: gitweb.snapshot
> no longer work as it worked before, for example neither 'gzip'
> nor 'bzip2' values work anymore ('zip' doesn't stop working).I realized after seeing your other message on this patch that this can be done while retaining backward compatibility, as you suggested. Matt, does Jakub's suggestion make sense to you?